Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small schema update #4060

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Small schema update #4060

merged 4 commits into from
Nov 4, 2024

Conversation

Martin-Zeithaml
Copy link
Contributor

Schema validation update for zowe.job.name and zowe.job.prefix:

  • validate as zowe job name

Partially for #3950.

Zowe.yaml

zowe:
  job:
    # Zowe JES job name
    name: '1111111111111111111111111'
    # Prefix of component address space
    prefix: '2222222222222222222222222222222222'

Without fix zwe start -c zowe.yaml

>> STARTING ZOWE

- opercmd S ZWESLSTC,HAINST=ca32,JOBNAME=1111111111111111111111111
  * Succeeded
  * Exit code: 0
  * Output:
    CA32      2024297  07:30:39.32             ISF031I CONSOLE ZEIMA02 ACTIVATED
    CA32      2024297  07:30:39.32            -S ZWESLSTC,HAINST=ca32,JOBNAME=1111111111111111111111111
    CA32      2024297  07:30:39.33             IEE308I START    TERM LENGTH ERROR
    .
ERROR: Error ZWEL0165E: Failed to start ZWESLSTC: IEE308I START    TERM LENGTH ERROR.

With fix zwe start -c zowe.yaml

Error: Validation of FILE(./zowe.yaml):FILE(/zowe/runtime/3000/files/defaults.yaml) against schema /zowe/runtime/3000/schemas/zowe-yaml-schema.json:/zowe/runtime/3000/schemas/server-common.json found invalid JSON Schema data
Validity Exceptions(s) with object at
  Validity Exceptions(s) with object at /zowe
    Validity Exceptions(s) with object at /zowe/job
      Validity Exceptions(s) with string at /zowe/job/name
        string too long (len=25) '1111111111111111111111111' 25 > MAX=8 at /zowe/job/name
        string pattern match fail s='1111111111111111111111111', pat='^([A-Z\$\#\@]){1}([A-Z0-9\$\#\@]){0,7}$', at /zowe/job/name
      Validity Exceptions(s) with string at /zowe/job/prefix
        string too long (len=34) '2222222222222222222222222222222222' 34 > MAX=8 at /zowe/job/prefix
        string pattern match fail s='2222222222222222222222222222222222', pat='^([A-Z\$\#\@]){1}([A-Z0-9\$\#\@]){0,7}$', at /zowe/job/prefix

Signed-off-by: Martin Zeithaml <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Oct 23, 2024

build 6322 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11479002867

Copy link

github-actions bot commented Oct 23, 2024

build 6323 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11479015519

Copy link

github-actions bot commented Oct 23, 2024

Test workflow 5624 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4060/zowe-3.1.0-pr-4060-6323-20241023114243.pax
Running on machine: zzow09
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11479143189

Copy link

github-actions bot commented Oct 23, 2024

Test workflow 5625 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4060/zowe-3.1.0-pr-4060-6322-20241023120009.pax
Running on machine: zzow10
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11479393181

Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link

github-actions bot commented Oct 30, 2024

build 6359 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11596359246

Copy link

github-actions bot commented Oct 30, 2024

Test workflow 5638 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4060/zowe-3.1.0-pr-4060-6359-20241030152856.pax
Running on machine: zzow11
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11596469623

@MarkAckert MarkAckert added the Build: None Used in CI label Nov 4, 2024
@MarkAckert MarkAckert merged commit 0b1c273 into v3.x/staging Nov 4, 2024
7 of 8 checks passed
@MarkAckert MarkAckert deleted the v3.x/feature/schemaUpdate branch November 4, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build: None Used in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants