Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one last test #2355

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Fix one last test #2355

merged 4 commits into from
Nov 8, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Nov 7, 2024

What It Does

APIML in V3 only sets up the ibmzosmf endpoint. This test should only test for the presence of the default endpoint and the basepath.

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn!

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.16%. Comparing base (6ed09fc) to head (612d6ba).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2355      +/-   ##
==========================================
+ Coverage   91.15%   91.16%   +0.01%     
==========================================
  Files         636      636              
  Lines       18039    18039              
  Branches     3879     3879              
==========================================
+ Hits        16444    16446       +2     
+ Misses       1594     1592       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 7, 2024

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
thanks for using the one available by default 😋

@zFernand0 zFernand0 merged commit 192a3d7 into master Nov 8, 2024
17 checks passed
@zFernand0 zFernand0 deleted the last-system-test branch November 8, 2024 15:43
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

7 participants