-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix one last test #2355
Fix one last test #2355
Conversation
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @awharn!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2355 +/- ##
==========================================
+ Coverage 91.15% 91.16% +0.01%
==========================================
Files 636 636
Lines 18039 18039
Branches 3879 3879
==========================================
+ Hits 16444 16446 +2
+ Misses 1594 1592 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
thanks for using the one available by default 😋
What It Does
APIML in V3 only sets up the
ibmzosmf
endpoint. This test should only test for the presence of the default endpoint and the basepath.How to Test
Review Checklist
I certify that I have:
Additional Comments