[v3] Zos files attributes #2319
Conversation
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2319 +/- ##
========================================
Coverage 91.10% 91.10%
========================================
Files 628 628
Lines 17887 17891 +4
Branches 3736 3844 +108
========================================
+ Hits 16296 16300 +4
Misses 1590 1590
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/zosfiles/__tests__/__system__/methods/upload/Upload.system.test.ts
Fixed
Show fixed
Hide fixed
packages/zosfiles/__tests__/__system__/methods/upload/Upload.system.test.ts
Fixed
Show fixed
Hide fixed
packages/zosfiles/__tests__/__system__/methods/upload/Upload.system.test.ts
Fixed
Show fixed
Hide fixed
packages/zosfiles/__tests__/__system__/methods/upload/Upload.system.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
packages/zosfiles/__tests__/__system__/methods/upload/Upload.system.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
jace-roell
requested review from
t1m0thyj,
gejohnston,
zFernand0,
awharn,
traeok,
anaxceron,
ATorrise and
adam-wolfe
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
|
This seems to be working as expected. I'm wondering if we should also add this option for |
packages/zosfiles/__tests__/__system__/methods/upload/testfiles/encodingCheck.txt
Outdated
Show resolved
Hide resolved
packages/zosfiles/__tests__/__system__/methods/upload/testfiles/encodingCheck.txt
Outdated
Show resolved
Hide resolved
…e -> public function signature Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
|
| * This program and the accompanying materials are made available under the terms of the | ||
| * Eclipse Public License v2.0 which accompanies this distribution, and is available at | ||
| * https://www.eclipse.org/legal/epl-v20.html | ||
| * | ||
| * SPDX-License-Identifier: EPL-2.0 | ||
| * | ||
| * Copyright Contributors to the Zowe Project. | ||
| * | ||
| */ | ||
| * This program and the accompanying materials are made available under the terms of the | ||
| * Eclipse Public License v2.0 which accompanies this distribution, and is available at | ||
| * https://www.eclipse.org/legal/epl-v20.html | ||
| * | ||
| * SPDX-License-Identifier: EPL-2.0 | ||
| * | ||
| * Copyright Contributors to the Zowe Project. | ||
| * | ||
| */ |
There was a problem hiding this comment.
curious how this happens since running npm run build seems to take those extra spaces away 🤔
This makes me wonder if we should implement prettier (or similar tools) as pre-commit hooks (like husky) 😋
👀 @t1m0thyj, any thoughts?
There was a problem hiding this comment.
Not saying that this needs to be updated as part of this PR 😋
|
Since there are no outstanding comments pending for changes, it seems that this PR can be merged as-is 🥳 Thanks for all the great work on this 🥳 |
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Added optional
--attributesflag tozowe zos-files upload file-to-ussto allow passing a .zosattributes file path for upload encoding format.Review Checklist
I certify that I have: