Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test-utils): Enhance the CLI Test Utils to support workspaces #1780

Merged
merged 8 commits into from
Aug 16, 2023

Conversation

zFernand0
Copy link
Member

@zFernand0 zFernand0 commented Aug 8, 2023

What It Does

Allows for monorepos (like the CICS-for-Zowe-Client) to have its test results and test resources in the individual packages of the monorepo instead of at the root of the project.

How to Test

Review Checklist
I certify that I have:

Additional Comments

This may (or may not) be a blocker to the CICS Monorepo work 😋

Also, we could get this changes published with whatever CLI PR goes out next 😋

@zFernand0 zFernand0 self-assigned this Aug 8, 2023
Signed-off-by: zFernand0 <[email protected]>
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ee1e2bd) 92.82% compared to head (24bf78f) 92.82%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1780   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         423      423           
  Lines        7191     7191           
  Branches     1319     1319           
=======================================
  Hits         6675     6675           
  Misses        515      515           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zFernand0 zFernand0 mentioned this pull request Aug 9, 2023
4 tasks
@zFernand0 zFernand0 changed the title feat(test-utils): Enhance the CLI Test Utils to further support works… feat(test-utils): Enhance the CLI Test Utils to support workspaces Aug 9, 2023
@awharn awharn self-requested a review August 9, 2023 16:29
@JTonda JTonda requested a review from awharn August 14, 2023 15:14
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever solution to support different project structures for monorepos 😋

Copy link
Member

@awharn awharn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed all of the tests failing in exactly the same way, should investigate before any kind of merge is done.

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zFernand0 zFernand0 merged commit 7d6ead5 into master Aug 16, 2023
22 checks passed
@zFernand0 zFernand0 deleted the enhance-cli-test-utils branch August 16, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants