chore: remove CLI preinstall/keytar script; bump Secrets SDK to 7.18.0 #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1775 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 423 423
Lines 7165 7165
Branches 1308 1308
=======================================
Hits 6648 6648
Misses 516 516
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <[email protected]>
traeok
force-pushed
the
chore/bump-secrets-sdk
branch
from
7edc80f
to
f88e3d4
Compare
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
traeok
requested review from
t1m0thyj,
gejohnston,
zFernand0,
awharn,
KevinLoesch1,
ATorrise and
adam-wolfe
t1m0thyj
approved these changes
Aug 4, 2023
gejohnston
approved these changes
Aug 4, 2023
zFernand0
approved these changes
Aug 4, 2023
| @@ -42,7 +42,6 @@ | |||
| "main": "lib/index.js", | |||
| "typings": "lib/index.d.ts", | |||
| "scripts": { | |||
| "preinstall": "node ./scripts/preinstall", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
This PR:
preinstallscript from the CLI package as its no longer neededbundleKeytar.shscript from the root of the repo7.18.0to be in-line with CLI