-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle new APIML unique cookie identifier #1734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small observation
Signed-off-by: zFernand0 <[email protected]>
…th login Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
…th='/' Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
…ne already Signed-off-by: zFernand0 <[email protected]>
…as we get a token Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
...ges/cli/__tests__/auth/__integration__/__snapshots__/cli.auth.apiml.integration.test.ts.snap
Show resolved
Hide resolved
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
…ofiles Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0 😃
Signed-off-by: zFernand0 <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
logout
operation with invalid and/or expired tokensHow to Test
Note: you may need to build the APIML (https://github.com/zowe/api-layer) locally in order to configure it to use unique cookie identifiers
Commands to try:
zowe auth login apiml
zowe auth logout apiml
zowe config secure
zowe config auto-init
Scenarios from Imperative:
config secure
commandtokenValue
in the secure arrayProcessing secure properties for profile: <profile_name>
abovezowe auth login apiml
operation and then remove the token from the vaullttokenValue
(which will ask foruser:password
to login)doAutoInit
functionality since theuser:password
are still provided in the ISessionReverted scenario:
allowed logout operation to remove token type and/or token value when either is not specified in the config filetokenType
ortokenValue
Review Checklist
I certify that I have:
Additional Comments
zowe auth login apiml
creates additional base profiles #1650