create sigstore signature for cli bundles #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
MarkAckert
changed the title
zFernand0
approved these changes
Oct 2, 2024
t1m0thyj
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Not very familiar with Sigstore bundles and how we plan to use them, but changes LGTM - thanks @MarkAckert 😋
|
They're replacing the GPG artifact signatures we've used up to now, and means we don't have to manage private keys anymore. We have instructions on how to use the sigstore bundles to validate artifacts on the zowe.org download page for PAX, SMPE and PSWI :-) . I'll add CLI in with the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
This PR adds sigstore signatures to the SDK and CLI standalone packages.
How to Test
Run the workflow.
Review Checklist
I certify that I have: