Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary banner from layout #7221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove temporary banner from layout #7221

wants to merge 1 commit into from

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Nov 19, 2024 •
edited
Loading

Staging branch URL: https://pr-7221.pfe-preview.zooniverse.org/projects

Reverts: #7217
Corresponding FEM PR: zooniverse/front-end-monorepo#6479

How To Review

The temporary banner should no longer be visible at the above staged url.

@goplayoutside3 goplayoutside3 mentioned this pull request Nov 19, 2024
Open
3 tasks
@coveralls
Copy link

Coverage Status

coverage: 56.684% (+0.03%) from 56.659%
when pulling 7400ab8 on remove-temp-banner
into 2342b1f on master.

shaunanoordin
shaunanoordin approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@shaunanoordin shaunanoordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

This is a straightforward removal of the temporary banner element. LGTM, merge & deploy whenever the downtime is complete. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunanoordin shaunanoordin shaunanoordin approved these changes

Assignees

@kieftrav kieftrav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goplayoutside3 @coveralls @shaunanoordin @kieftrav