improve converting to Go string performance #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to out of place performance on this bench for large case i thought there could be easy performance wins.
Profiling on that, performance hit as the string got bigger due to this loop https://github.com/zombiezen/go-sqlite/blob/f46dbf8b767e074a46642cd87c3d0e0cafcc79b2/sqlite.go#L1297C2-L1308
This PR instead convert to unsafe string all at once and then clone it to get safe string. The performance for 1 byte string is the same and then keep improving as the string get bigger.
~40% improvement for the large case on the benchmark. Also improve performance of other benchmark cases slightly.