Skip to content

Commit

Permalink
fix extensions order in save dialog
Browse files Browse the repository at this point in the history
  • Loading branch information
daiyam committed Jul 29, 2020
1 parent e04109d commit 2d8b80b
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 1 deletion.
3 changes: 3 additions & 0 deletions _create_patch_dialog.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
cd vscodium/vscode

git diff > ../../patches/dialog-save-options.patch
2 changes: 1 addition & 1 deletion build_macos_dev.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ cd vscodium

gsed -i -E 's/\.\/prepare\_vscode\.sh/# .\/prepare_vscode.sh/g' build.sh

SHOULD_BUILD=yes CI_BUILD=no TRAVIS_OS_NAME=osx LATEST_MS_COMMIT='1.46.0'. build.sh
SHOULD_BUILD=yes CI_BUILD=no TRAVIS_OS_NAME=osx LATEST_MS_COMMIT='1.47.3'. build.sh
14 changes: 14 additions & 0 deletions patches/dialog-save-options.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
diff --git a/src/vs/workbench/services/dialogs/browser/abstractFileDialogService.ts b/src/vs/workbench/services/dialogs/browser/abstractFileDialogService.ts
index 1260a83..6bd0f8f 100644
--- a/src/vs/workbench/services/dialogs/browser/abstractFileDialogService.ts
+++ b/src/vs/workbench/services/dialogs/browser/abstractFileDialogService.ts
@@ -294,8 +294,8 @@ export abstract class AbstractFileDialogService implements IFileDialogService {
// - All Languages
// - No Extension
options.filters = coalesce([
- matchingFilter,
{ name: nls.localize('allFiles', "All Files"), extensions: ['*'] },
+ matchingFilter,
...filters,
{ name: nls.localize('noExt', "No Extension"), extensions: [''] }
]);
1 change: 1 addition & 0 deletions prepare.sh
Original file line number Diff line number Diff line change
Expand Up @@ -181,5 +181,6 @@ gsed -i -E '{N; N; N; s|Visual Studio Code.*\n.*\n.*|MrCode is an editor based o
git apply --3way ../../patches/binary-name.patch
git apply --3way ../../patches/editor-open-positioning--sort.patch
git apply --3way ../../patches/editor-folding-strategy--custom.patch
git apply --3way ../../patches/dialog-save-options.patch

cd ..

0 comments on commit 2d8b80b

Please sign in to comment.