Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fallbacks #10

Merged
merged 1 commit into from
Jun 29, 2018
Merged

add fallbacks #10

merged 1 commit into from
Jun 29, 2018

Conversation

justinbastress
Copy link
Contributor

Re: issues #7 and #9.

If the long field is missing but json is present, use the latter as the long key.

If the env field is missing but long (or json) is present, use the long name for the environment variable.

Should save us from a lot of duplication.

@justinbastress justinbastress mentioned this pull request Jun 29, 2018
Closed
@zakird zakird merged commit 8aa1882 into master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakird zakird zakird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinbastress @zakird