Add Mikado hook as a featured import method for SDVX #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this hook supercedes barbatos then maybe you can inherit all of the barbatos descriptions, and barbatos can be marked as deprecated/for older versions of sdvx? I'm not up to date with what works on what anymore. That's what I'd do anyway. Neat that the source code for this is public. Very interesting to see the rust guts of hooking into DLLs like this :P |
adamaq01
force-pushed
the
mikado-importer
branch
from
68ba8ce to
23ba94b
Compare
adamaq01
force-pushed
the
mikado-importer
branch
from
7b441b3 to
db7c3d0
Compare
zkrising
pushed a commit
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a link of the hook's source code: https://github.com/adamaq01/mikado
On the discord it seemed that some people were interested in it being featured so here's the PR.
There are some places where I am not sure what to put (for example the description of the hook, since theres also Barbatos) so I put some TODOs in there. It would be great to discuss about what these should be.
Same thing for the position on the webpage etc...
Marking it as a draft until this is resolved :)