Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore empty json strings for locale #678

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

muhlemmer
Copy link
Collaborator

This change reverts fbf009f so that any non-value error is returned again.
Instead, a check is done for an empty JSON string.

Extra test cases of missing / null / empty values are also added.

This is an alternative solution for #672

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@muhlemmer muhlemmer marked this pull request as ready for review November 11, 2024 10:37
@muhlemmer
Copy link
Collaborator Author

@muir can you have a look if this alternative does not re-introduce the okta issue you had?

@muir
Copy link
Contributor

muir commented Nov 12, 2024

@muir can you have a look if this alternative does not re-introduce the okta issue you had?

This should be fine. I don't think I would ever want authorization to be blocked by a bad locale though -- I'm not using the locale and thus it has no value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants