Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show method for render statements #988

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Show method for render statements #988

wants to merge 2 commits into from

Conversation

GrigoriiBerezin
Copy link

  • add show method for statements
  • add tests on show for all sql dialects
  • add show info in README

@GrigoriiBerezin GrigoriiBerezin requested a review from a team as a code owner April 29, 2024 12:56
@GrigoriiBerezin
Copy link
Author

@jczuchnowski review plz when you will have free time.
Have some thoughts about inheritance Read, Update, Insert and Delete from one trait to have one type class with pattern matching for all statements
P.S. don't understand why website job is failing also

@GrigoriiBerezin
- add show method for statements
d465799 
- add tests on `show` for all sql dialects
- add `show` info in README
@GrigoriiBerezin GrigoriiBerezin force-pushed the add_show_and_tests branch 2 times, most recently from 6a54403 to b3c8ae8 Compare April 29, 2024 13:14
@GrigoriiBerezin
- add show method for statements
80f7afd 
- add tests on `show` for all sql dialects
- add `show` info in README
Grryum
Grryum reviewed May 3, 2024
View reviewed changes
core/jvm/src/main/scala/zio/sql/Sql.scala
@@ -54,6 +54,22 @@ trait Sql {

def renderInsert[A: Schema](insert: Insert[_, A]): SqlStatement

implicit class readOps(read: Read[_]) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that this implicit class should extend AnyVal

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, thx, will fix it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, can't do it due to show method dependency on realization of trait, which is prohibited for value class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grryum Grryum Grryum left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrigoriiBerezin @Grryum