Read args from file, merge args and pass to the cmd. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I have not changed any file in zio-cli-docs yet it throws this error. should i try to fix it?? [info] [webpackbar] Compiling Client
[info] [webpackbar] Compiling Server
[success] [webpackbar] Client: Compiled with some errors in 27.48s
Error: Client bundle compiled with errors therefore further build is impossible.
Module parse failed: Unexpected token (961:17)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| 'special-attr': [],
| 'attr-value': {
> pattern: /=\s*(?:"[^"]*"|'[^']*'|[^\s'">=]+)/,
| inside: {
| 'punctuation': [{
[error] java.lang.RuntimeException: Failed to build the website!
[error] at scala.sys.package$.error(package.scala:30)
[error] at zio.sbt.WebsitePlugin$.exit(WebsitePlugin.scala:135)
[error] at zio.sbt.WebsitePlugin$.$anonfun$buildWebsiteTask$1(WebsitePlugin.scala:[204](https://github.com/zio/zio-cli/actions/runs/6658650685/job/18095973316?pr=278#step:7:205))
[error] at zio.sbt.WebsitePlugin$.$anonfun$buildWebsiteTask$1$adapted(WebsitePlugin.scala:200)
[error] at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error] at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:63)
[error] at sbt.std.Transform$$anon$4.work(Transform.scala:69)
[error] at sbt.Execute.$anonfun$submit$2(Execute.scala:283)
[error] at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:24)
[error] at sbt.Execute.work(Execute.scala:292)
[error] at sbt.Execute.$anonfun$submit$1(Execute.scala:283)
[error] at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[error] at sbt.CompletionService$$anon$2.call(CompletionService.scala:65)
[error] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error] at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
[error] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[error] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[error] at java.base/java.lang.Thread.run(Thread.java:840)
[error] (docs / buildWebsite) Failed to build the website! |
pablf
reviewed
Oct 27, 2023
| self.command | ||
| .parse(prefix(self.command) ++ args, self.config) | ||
| .parse(prefix(self.command) ++ arg_from_config_files ++ args, self.config) |
There was a problem hiding this comment.
Hi! I don't think including arg_from_config_files there would work. It's probably best to do this inside command.parse so you can have more control in how args are parsed.
There was a problem hiding this comment.
ok move it inside command.parse
jdegoes
reviewed
Jan 10, 2024
| @@ -56,6 +57,75 @@ object CliApp { | |||
| def printDocs(helpDoc: HelpDoc): UIO[Unit] = | |||
| printLine(helpDoc.toPlaintext(80)).! | |||
|
|
|||
| def checkAndGetOptionsFilePaths(topLevelCommand: String): List[String] = { | |||
There was a problem hiding this comment.
This is side-effecting, so should return Task[List[String]] for consistency with the rest of ZIO ecosystem.
jdegoes
reviewed
Jan 10, 2024
| // Read the contents of the files at the given file paths | ||
| val options: List[String] = filePaths.flatMap { filePath => | ||
| val source = scala.io.Source.fromFile(filePath) | ||
| source.getLines().toList |
There was a problem hiding this comment.
This creates a leak because the source is never closed. Also, it's an inefficient way to read a file. Better to use something like ZIO.readFile.
jdegoes
requested changes
Jan 10, 2024
|
@jdegoes thanks for the comment. I will update and commit changes soon. |
|
@vivasvan1 Please do try to fix any CI error. 🙏 |
|
@vivasvan1 Please re-open if you get a chance to fix conflicts! 🙏 |
jdegoes
reviewed
Apr 19, 2024
| @@ -115,8 +185,9 @@ object CliApp { | |||
| case Command.Subcommands(parent, _) => prefix(parent) | |||
| } | |||
|
|
|||
| val arg_from_config_files = loadOptionsFromFile(self.name) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #191
closes #191