fix single structure upload (#736)

* fix single structure upload * fix upload append (test this) * bugfix in place update
zincware · Nov 18, 2024 · 7c7286b · 7c7286b
1 parent 32507bc
commit 7c7286b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/app/src/components/api.tsx b/app/src/components/api.tsx
@@ -351,7 +351,8 @@ export const setupFrames = (
 			if (x?.start > step && frame_update) {
 				setStep(x.start);
 			} else if (x?.start === step) {
-				setStep(x.start);
+				const frame = await currentRoomCon.get(step);
+				setCurrentFrameFromObject(frame);
 			} else if (x?.indices?.includes(step)) {
 				const frame = await currentRoomCon.get(step);
 				setCurrentFrameFromObject(frame);
@@ -368,7 +369,9 @@ export const setupFrames = (
 			if (x?.start > step && frame_update) {
 				setStep(x.start);
 			} else if (x?.start === step) {
-				setStep(x.start);
+				// this should never happen?
+				const frame = await defaultRoomCon.get(step);
+				setCurrentFrameFromObject(frame);
 			} else if (x?.indices?.includes(step)) {
 				const frame = await defaultRoomCon.get(step);
 				setCurrentFrameFromObject(frame);

diff --git a/zndraw/upload.py b/zndraw/upload.py
@@ -29,9 +29,7 @@ def upload(
     typer.echo(f"Uploading to: {url}/token/{vis.token}")
 
     if not append:
-        size = len(vis)
-        print(f"Deleting {size} existing figures ...")
-        del vis[: size - 1]
+        del vis[:]
     typer.echo(f"Reading {fileio.name} ...")
 
     generator = get_generator_from_filename(fileio)
@@ -41,9 +39,7 @@ def upload(
     if browser:
         webbrowser.open(f"{url}/token/{vis.token}")
 
-    if not append:
-        # There must be a frame otherwise removing everything currently doesn't work
-        del vis[0]
-    vis.extend(frames[1:])
+    if len(frames) > 1:
+        vis.extend(frames[1:])
 
     vis.figures.update(load_plots_to_dict(plots, fileio.remote, fileio.rev))