Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-2022 | Lighthouse report based fixes #270

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

stephanoshadjipetrou
Copy link
Member

No description provided.

Copy link

cypress bot commented Nov 21, 2024

Dataxplorer    Run #611

Run Properties:  status check failed Failed #611  •  git commit 788f78bd01 ℹ️: Merge 67c2c02b555597ec1306f5ebbf9ee276bd059a34 into 27aa09fefb7f0cedd23d164f84b8...
Project Dataxplorer
Branch Review feat/DX-2022
Run status status check failed Failed #611
Run duration 01m 55s
Commit git commit 788f78bd01 ℹ️: Merge 67c2c02b555597ec1306f5ebbf9ee276bd059a34 into 27aa09fefb7f0cedd23d164f84b8...
Committer Stefanos Hadjipetrou
View all properties for this run ↗︎

Test results
Tests that failed  Failures 11
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 18
Tests that passed  Passing 0
View all changes introduced in this branch ↗︎

Tests for review

Failed  1-test-login.cy.ts • 1 failed test

View Output

Test Artifacts
Login for a test user on DX > Is Logged in Test Replay Screenshots
Failed  2-datasets.cy.ts • 2 failed tests

View Output

Test Artifacts
Testing connecting data on DX > Can filter results by source in the federated search Test Replay Screenshots
Edit, Delete and Duplicate Dataset > Can Edit a Dataset Test Replay Screenshots
Failed  3-charts.cy.ts • 3 failed tests

View Output

Test Artifacts
Testing create chart on DX > Can create a bar chart Test Replay Screenshots
Testing Ai chart creation > Can create a chart with AI Test Replay Screenshots
Edit, duplicate and delete chart > Can Edit a chart Test Replay Screenshots
Failed  4-reports.cy.ts • 2 failed tests

View Output

Test Artifacts
Testing reports on DX > Can Create report Test Replay Screenshots
Edit, duplicate and delete report > Can Edit a report Test Replay Screenshots
Failed  5-dashboard.cy.ts • 1 failed test

View Output

Test Artifacts
Dashboard > Can view all asset types on the dashboard Test Replay Screenshots

The first 5 failed specs are shown, see all 7 specs in Cypress Cloud.

@@ -45,3 +45,11 @@ declare module '*.svg' {
const src: string;
export default src;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanoshadjipetrou is this absolutely necessary? It causes an error in every file that has an import from the "react" module. See image for example
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okorie2 if you remove this then it works ok?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okorie2 ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants