Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed secret name for cert volume #223

Closed

Conversation

nustiueudinastea
Copy link
Contributor

This PR adds the secretName to the cert volume. Without this, the deployment does not work.

@sre-ci-robot
Copy link
Collaborator

Welcome @nustiueudinastea! It looks like this is your first PR to zilliztech/milvus-operator 🎉

@haorenfsa
Copy link
Collaborator

Hi @nustiueudinastea , please sign-off your commit https://github.com/zilliztech/milvus-operator/pull/223/checks?check_run_id=34545135221

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (d7a4a66) to head (4010b83).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   80.70%   80.70%           
=======================================
  Files          56       56           
  Lines        6234     6234           
=======================================
  Hits         5031     5031           
  Misses       1014     1014           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nustiueudinastea
Copy link
Contributor Author

@haorenfsa I signed my commit

@haorenfsa haorenfsa added the lgtm looks good to merge label Dec 18, 2024
@haorenfsa
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, nustiueudinastea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot removed the lgtm looks good to merge label Dec 19, 2024
@sre-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@nustiueudinastea
Copy link
Contributor Author

nustiueudinastea commented Dec 19, 2024

Hey @haorenfsa, made another change, which explicitly sets the webhook flag when enableWebhook parameter is set to true. This is needed because by default, the webhook flag is set to false. So the previous config was not doing anything.

This is to what I am referring:

flag.BoolVar(&enableWebhook, "webhook", false, "Enable webhook for support of v1alpha1 crd & validation")

@haorenfsa
Copy link
Collaborator

Thank you @nustiueudinastea, your 2nd commit was not signed off

@haorenfsa haorenfsa mentioned this pull request Jan 3, 2025
@haorenfsa
Copy link
Collaborator

Hi @nustiueudinastea , I'm following this patch in #227. Thank you for your contribution!

@haorenfsa haorenfsa closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants