-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed secret name for cert volume #223
fixed secret name for cert volume #223
Conversation
Welcome @nustiueudinastea! It looks like this is your first PR to zilliztech/milvus-operator 🎉 |
Hi @nustiueudinastea , please sign-off your commit https://github.com/zilliztech/milvus-operator/pull/223/checks?check_run_id=34545135221 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
=======================================
Coverage 80.70% 80.70%
=======================================
Files 56 56
Lines 6234 6234
=======================================
Hits 5031 5031
Misses 1014 1014
Partials 189 189 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Giurgiu <[email protected]>
1c67d63
to
011c2d0
Compare
@haorenfsa I signed my commit |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haorenfsa, nustiueudinastea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…t, because by default its set to false
New changes are detected. LGTM label has been removed. |
Hey @haorenfsa, made another change, which explicitly sets the webhook flag when enableWebhook parameter is set to true. This is needed because by default, the webhook flag is set to false. So the previous config was not doing anything. This is to what I am referring: Line 71 in d7a4a66
|
Thank you @nustiueudinastea, your 2nd commit was not signed off |
Hi @nustiueudinastea , I'm following this patch in #227. Thank you for your contribution! |
This PR adds the secretName to the cert volume. Without this, the deployment does not work.