optimize

zilliztech · Aug 6, 2024 · 66ffe17 · 66ffe17
1 parent 797c4b7
commit 66ffe17
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/core/dbclient/milvus2x.go b/core/dbclient/milvus2x.go
@@ -75,7 +75,7 @@ func NewMilvus2xClient(cfg *config.Milvus2xConfig) (*Milvus2x, error) {
 		zap.Int("GrpcMaxCallRecvMsgSize", cfg.GrpcMaxRecvMsgSize),
 		zap.Int("GrpcMaxCallSendMsgSize", cfg.GrpcMaxSendMsgSize))
 
-	if cfg.Database != "" && len(cfg.Database) > 0 {
+	if cfg.Database != "" {
 		err = useDatabase(cfg, milvus, ctx)
 		if err != nil {
 			return nil, err

diff --git a/core/loader/cus_milvus2x_loader.go b/core/loader/cus_milvus2x_loader.go
@@ -124,7 +124,7 @@ func (this *CustomMilvus2xLoader) compareResult(ctx context.Context) error {
 func (this *CustomMilvus2xLoader) BatchWrite(ctx context.Context, data *milvus2x.Milvus2xData) error {
 
 	log.LL(ctx).Info("[Loader] Begin to batchWrite data to milvus", zap.String("collection", this.runtimeCollectionNames[0]))
-	if this.cfg.TargetMilvus2xCfg.WriteMode != "" && this.cfg.TargetMilvus2xCfg.WriteMode == common.UPSERT {
+	if this.cfg.TargetMilvus2xCfg.WriteMode == common.UPSERT {
 		return this.CusMilvus2x.StartBatchUpsert(ctx, this.runtimeCollectionNames[0], data)
 	} else {
 		return this.CusMilvus2x.StartBatchInsert(ctx, this.runtimeCollectionNames[0], data)

diff --git a/storage/milvus2x/milvus2_3_ver.go b/storage/milvus2x/milvus2_3_ver.go
@@ -156,7 +156,7 @@ func _createMilvus23VerClient(cfg *config.Milvus2xConfig) (*Milvus23VerClient, e
 		zap.Int("GrpcMaxCallRecvMsgSize", cfg.GrpcMaxRecvMsgSize),
 		zap.Int("GrpcMaxCallSendMsgSize", cfg.GrpcMaxSendMsgSize))
 
-	if cfg.Database != "" && len(cfg.Database) > 0 {
+	if cfg.Database != "" {
 		err := milvus.UsingDatabase(ctx, cfg.Database)
 		if err != nil {
 			return nil, err