Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[milvus] <fix>: Add child Chart MinIO configuration to Milvus level #46

Closed
wants to merge 1 commit into from

Conversation

wyfeng001
Copy link
Contributor

What this PR does / why we need it:

  1. If we don't add it, helm will report an error when minio is disabled. For the specific reason, see template/config.tpl:59
  2. If not all of ths tls configs are raised (i.e just add tls: enable to the parent chart values), when the user enables tls, he needs to add Key/Cert to the sub-Chart. Therefore, all TLS-related configurations are brought up to Milvus Chart Values.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wyfeng001
To complete the pull request process, please assign loveeachday after the PR has been reviewed.
You can assign the PR to them by writing /assign @loveeachday in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants