Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mysql as metastore #33

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/milvus/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: milvus
appVersion: "2.3.2"
kubeVersion: "^1.10.0-0"
description: Milvus is an open-source vector database built to power AI applications and vector similarity search.
version: 4.1.7
version: 4.1.8
keywords:
- milvus
- elastic
Expand Down
17 changes: 2 additions & 15 deletions charts/milvus/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ extraConfigFiles:

So if you had deployed a cluster with helm chart version below 4.0.0 and also specified extra config, you need set the configs under `extraConfigFiles` when running `helm upgrade`.

> **IMPORTANT** Milvus has removed mysql as meta store support from v2.3.1. And milvus helm chart has also removed mysql as dependency from chart version 4.1.8.

### Enable log to file

By default, all the logs of milvus components will output stdout. If you wanna log to file, you'd install milvus with `--set log.persistence.enabled=true`. Note that you should have a storageclass with `ReadWriteMany` access modes.
Expand Down Expand Up @@ -223,14 +225,6 @@ The following table lists the configurable parameters of the Milvus Service and
| `externalKafka.sasl.mechanisms` | SASL mechanism to use for kafka authentication | `PLAIN` |
| `externalKafka.sasl.username` | username for PLAIN or SASL/PLAIN authentication | `` |
| `externalKafka.sasl.password` | password for PLAIN or SASL/PLAIN authentication | `` |
| `externalMysql.enabled` | Enable or disable external MySQL | `false` |
| `externalMysql.username` | MySQL username | `` |
| `externalMysql.password` | MySQL password | `` |
| `externalMysql.address` | MySQL address | `localhost` |
| `externalMysql.port` | MySQL port | `3306` |
| `externalMysql.dbName` | MySQL meta database | `milvus_meta` |
| `externalMysql.maxOpenConns` | MySQL client maxOpenConns | `20` |
| `externalMysql.maxIdleConns` | MySQL client maxIdleConns | `5` |

### Milvus Standalone Deployment Configuration

Expand Down Expand Up @@ -471,13 +465,6 @@ This version of the chart includes the dependent Kafka chart in the charts/ dire
You can find more information at:
* [https://artifacthub.io/packages/helm/bitnami/kafka](https://artifacthub.io/packages/helm/bitnami/kafka)

### MySQL Configuration

This version of the chart includes the dependent MySQL chart in the charts/ directory.

You can find more information at:
* [https://artifacthub.io/packages/helm/bitnami/mysql](https://artifacthub.io/packages/helm/bitnami/mysql)

### Milvus Live Profiling
Profiling is an effective way of understanding which parts of your application are consuming the most resources.

Expand Down
Binary file removed charts/milvus/charts/mysql-8.5.3.tgz
Binary file not shown.
7 changes: 2 additions & 5 deletions charts/milvus/requirements.lock
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,5 @@ dependencies:
- name: kafka
repository: https://raw.githubusercontent.com/bitnami/charts/pre-2022/bitnami
version: 15.5.1
- name: mysql
repository: https://raw.githubusercontent.com/bitnami/charts/pre-2022/bitnami
version: 8.5.3
digest: sha256:7810d86cff203549e8b9dbd8d4776cac1267a62087c80cdb5104dc475e952e9f
generated: "2023-08-17T18:00:58.85315+08:00"
digest: sha256:22f3e5901ec8363dcc764d95376a6190e96ae40bb5dbe2bfb7c93a113c1e294f
generated: "2023-10-30T14:45:53.542457+08:00"
6 changes: 0 additions & 6 deletions charts/milvus/requirements.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,3 @@ dependencies:
condition: kafka.enabled
tags:
- kafka
- name: mysql
version: 8.5.3
repository: https://raw.githubusercontent.com/bitnami/charts/pre-2022/bitnami
condition: mysql.enabled
tags:
- mysql
38 changes: 0 additions & 38 deletions charts/milvus/templates/config.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -26,45 +26,7 @@ etcd:
{{- end }}

metastore:
{{- if or .Values.mysql.enabled .Values.externalMysql.enabled }}
type: mysql
{{- else }}
type: etcd
{{- end }}

{{- if .Values.externalMysql.enabled }}
mysql:
username: {{ .Values.externalMysql.username }}
password: {{ .Values.externalMysql.password }}
address: {{ .Values.externalMysql.address }}
port: {{ .Values.externalMysql.port }}
dbName: {{ .Values.externalMysql.dbName }}
driverName: mysql
maxOpenConns: {{ .Values.externalMysql.maxOpenConns }}
maxIdleConns: {{ .Values.externalMysql.maxIdleConns }}
{{- else if .Values.mysql.enabled }}
mysql:
username: root
password: {{ .Values.mysql.auth.rootPassword }}
{{- if contains .Values.mysql.name .Release.Name }}
{{- if eq .Values.mysql.architecture "replication" }}
address: {{ .Release.Name }}-primary
{{- else }}
address: {{ .Release.Name }}
{{- end }}
{{- else }}
{{- if eq .Values.mysql.architecture "replication" }}
address: {{ .Release.Name }}-{{ .Values.mysql.name }}-primary
{{- else }}
address: {{ .Release.Name }}-{{ .Values.mysql.name }}
{{- end }}
{{- end }}
port: 3306
dbName: {{ .Values.mysql.auth.database }}
driverName: mysql
maxOpenConns: {{ .Values.mysql.maxOpenConns }}
maxIdleConns: {{ .Values.mysql.maxIdleConns }}
{{- end }}

minio:
{{- if .Values.externalS3.enabled }}
Expand Down
59 changes: 0 additions & 59 deletions charts/milvus/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -824,51 +824,6 @@ kafka:
enabled: true
replicaCount: 3

## Configuration values for the mysql dependency
## ref: https://artifacthub.io/packages/helm/bitnami/mysql
##
## MySQL used for meta store is testing internally

mysql:
enabled: false
name: mysql
image:
repository: bitnami/mysql
tag: 8.0.23-debian-10-r84

architecture: replication
auth:
rootPassword: "ChangeMe"
createDatabase: true
database: "milvus_meta"

maxOpenConns: 20
maxIdleConns: 5
primary:
name: primary
resources:
limits: {}
requests: {}
persistence:
enabled: true
storageClass: ""
accessModes:
- ReadWriteOnce
size: 100Gi

secondary:
name: secondary
replicaCount: 1
resources:
limits: {}
requests: {}
persistence:
enabled: true
storageClass: ""
accessModes:
- ReadWriteOnce
size: 100Gi

###################################
# External S3
# - these configs are only used when `externalS3.enabled` is true
Expand Down Expand Up @@ -932,17 +887,3 @@ externalKafka:
mechanisms: PLAIN
username: ""
password: ""

###################################
# External mysql
# - these configs are only used when `externalMysql.enabled` is true
###################################
externalMysql:
enabled: false
username: ""
password: ""
address: localhost
port: 3306
dbName: milvus_meta
maxOpenConns: 20
maxIdleConns: 5
Loading