Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Milvus] Add nodeSelector to Attu deployment #26

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

vladwa
Copy link
Contributor

@vladwa vladwa commented Oct 2, 2023

What this PR does / why we need it:

Include nodeSelectors in the Attu deployment to limit pod scheduling to specific dedicated nodes.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

Signed-off-by: Vinayaka Ladwa - v0l008y <[email protected]>
@vladwa
Copy link
Contributor Author

vladwa commented Oct 2, 2023

/assign @LoveEachDay Can you please review and approve.

Signed-off-by: Vinayaka Ladwa - v0l008y <[email protected]>
@vladwa vladwa changed the title [Milvus] Add nodeSelector to Attu deployments [Milvus] Add nodeSelector to Attu deployment Oct 3, 2023
@vladwa
Copy link
Contributor Author

vladwa commented Oct 3, 2023

/assign @LoveEachDay Can you please review and approve.

@haorenfsa
Copy link
Collaborator

/lgtm

@haorenfsa
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: haorenfsa, vladwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d33175b into zilliztech:master Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants