Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[milvus] allow to unset replicas field in autoscalable deployments #19

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

Archalbc
Copy link
Contributor

@Archalbc Archalbc commented Sep 20, 2023

What this PR does / why we need it:

Hi !

If users configure HPA on their side to control index/data/query/proxy pods Deployments, we need to remove the replicas field to avoid the bad well-known HPA behavior in case of rollout-update/apply.

kubernetes/kubernetes#25238

This feature will be necessary when HPA will be available in this chart again as well :)

Fix #16

Regards,

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@sre-ci-robot
Copy link
Collaborator

Welcome @Archalbc! It looks like this is your first PR to zilliztech/milvus-helm 🎉

@haorenfsa
Copy link
Collaborator

haorenfsa commented Oct 4, 2023

em.. I think the 0 value of replica is meaningful when we just want stop certain component. What about add a seperated feature gate value to enable it? Or a <0 value would also be ok to me. The rest looks good.
By the way, please rebase and bump the version again.

@mergify mergify bot added the ci-passed label Oct 4, 2023
@Archalbc
Copy link
Contributor Author

Archalbc commented Oct 5, 2023

em.. I think the 0 value of replica is meaningful when we just want stop certain component. What about add a seperated feature gate value to enable it? Or a <0 value would also be ok to me. The rest looks good. By the way, please rebase and bump the version again.

Thank you, following your idea, I pushed new changes and bumped the version.

Regards,

@haorenfsa
Copy link
Collaborator

@LoveEachDay PTAL

Copy link
Collaborator

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Archalbc, LoveEachDay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 097a219 into zilliztech:master Oct 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to unset the replicas field in Deployments
4 participants