-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[milvus] allow to unset replicas field in autoscalable deployments #19
Conversation
Welcome @Archalbc! It looks like this is your first PR to zilliztech/milvus-helm 🎉 |
e238294
to
79a02fd
Compare
em.. I think the |
Signed-off-by: ArchaLBC <[email protected]>
Thank you, following your idea, I pushed new changes and bumped the version. Regards, |
@LoveEachDay PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Archalbc, LoveEachDay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Hi !
If users configure HPA on their side to control index/data/query/proxy pods Deployments, we need to remove the replicas field to avoid the bad well-known HPA behavior in case of rollout-update/apply.
kubernetes/kubernetes#25238
This feature will be necessary when HPA will be available in this chart again as well :)
Fix #16
Regards,
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname]
)