S3 miss the region/useVirtualHost settings (#13)

Signed-off-by: mufu <[email protected]> Co-authored-by: mufu <[email protected]>
zilliztech · Oct 7, 2023 · 8df0802 · 8df0802
1 parent d33175b
commit 8df0802
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/charts/milvus/README.md b/charts/milvus/README.md
@@ -205,6 +205,8 @@ The following table lists the configurable parameters of the Milvus Service and
 | `externalS3.useIAM`                       | If true, use iam to connect to the external S3 | `false`                                                |
 | `externalS3.cloudProvider`                | When `useIAM` enabled, only "aws" & "gcp" is supported for now | `aws`                                  |
 | `externalS3.iamEndpoint`                  | The IAM endpoint of  the external S3 | ``                                                |
+| `externalS3.region`                  | The region of  the external S3 | ``                                                |
+| `externalS3.useVirtualHost`                  | If true, the external S3 whether use virtual host bucket mode | ``                                                |
 | `externalGcs.bucketName`                  | The Bucket Name of the external GCS. Requires GCS gateway to be enabled in the minIO configuration | `unset`                                                |
 | `externalEtcd.enabled`                    | Enable or disable external Etcd               | `false`                                                 |
 | `externalEtcd.endpoints`                  | The endpoints of the external etcd            | `{}`                                                    |

diff --git a/charts/milvus/templates/config.tpl b/charts/milvus/templates/config.tpl
@@ -78,6 +78,8 @@ minio:
   useIAM: {{ .Values.externalS3.useIAM }}
   cloudProvider: {{ .Values.externalS3.cloudProvider }}
   iamEndpoint: {{ .Values.externalS3.iamEndpoint }}
+  region: {{ .Values.externalS3.region }}
+  useVirtualHost: {{ .Values.externalS3.useVirtualHost }}
 {{- else }}
 {{- if contains .Values.minio.name .Release.Name }}
   address: {{ .Release.Name }}
@@ -96,6 +98,8 @@ minio:
   rootPath: {{ .Values.minio.rootPath }}
   useIAM: {{ .Values.minio.useIAM }}
   iamEndpoint: {{ .Values.minio.iamEndpoint }}
+  region: {{ .Values.minio.region }}
+  useVirtualHost: {{ .Values.minio.useVirtualHost }}
 {{- end }}
 
 {{- if .Values.externalPulsar.enabled }}

diff --git a/charts/milvus/values.yaml b/charts/milvus/values.yaml
@@ -441,6 +441,8 @@ minio:
   rootPath: file
   useIAM: false
   iamEndpoint: ""
+  region: ""
+  useVirtualHost: false
   podDisruptionBudget:
     enabled: false
   resources:
@@ -869,6 +871,8 @@ externalS3:
   useIAM: false
   cloudProvider: "aws"
   iamEndpoint: ""
+  region: ""
+  useVirtualHost: false
 
 ###################################
 # GCS Gateway