fix simple response possible NPE

Signed-off-by: wayblink <[email protected]>

core/backup_meta.go

@@ -280,6 +280,9 @@ func SimpleListBackupsResponse(input *backuppb.ListBackupsResponse) *backuppb.Li
 
 func SimpleBackupResponse(input *backuppb.BackupInfoResponse) *backuppb.BackupInfoResponse {
 	backup := input.GetData()
+	if backup == nil {
+		return input
+	}
 
 	collections := make([]*backuppb.CollectionBackupInfo, 0)
 	for _, coll := range backup.GetCollectionBackups() {
@@ -301,6 +304,9 @@ func SimpleBackupResponse(input *backuppb.BackupInfoResponse) *backuppb.BackupIn
 
 func SimpleRestoreResponse(input *backuppb.RestoreBackupResponse) *backuppb.RestoreBackupResponse {
 	restore := input.GetData()
+	if restore == nil {
+		return input
+	}
 
 	simpleRestore := proto.Clone(restore).(*backuppb.RestoreBackupTask)
 

core/backup_meta_test.go

@@ -231,3 +231,31 @@ func TestReadBackupFile(t *testing.T) {
 	fmt.Sprintf(segmentMetaStr)
 	//log.Info("segment meta", zap.String("value", string(output.SegmentMetaBytes)))
 }
+
+func TestSimpleBackupResponse(t *testing.T) {
+	info := &backuppb.BackupInfoResponse{
+		RequestId: "abc",
+		Code:      backuppb.ResponseCode_Success,
+		Msg:       "not found",
+		Data:      nil,
+	}
+	simpleInfo := SimpleBackupResponse(info)
+	assert.Nil(t, simpleInfo.Data)
+	assert.Equal(t, info.Code, simpleInfo.Code)
+	assert.Equal(t, info.Msg, simpleInfo.Msg)
+	assert.Equal(t, info.RequestId, simpleInfo.RequestId)
+}
+
+func TestSimpleRestoreResponse(t *testing.T) {
+	info := &backuppb.RestoreBackupResponse{
+		RequestId: "abc",
+		Code:      backuppb.ResponseCode_Success,
+		Msg:       "not found",
+		Data:      nil,
+	}
+	simpleInfo := SimpleRestoreResponse(info)
+	assert.Nil(t, simpleInfo.Data)
+	assert.Equal(t, info.Code, simpleInfo.Code)
+	assert.Equal(t, info.Msg, simpleInfo.Msg)
+	assert.Equal(t, info.RequestId, simpleInfo.RequestId)
+}