Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip e2e] Automated Update Cardinal Commit #699

Conversation

sre-ci-robot
Copy link
Collaborator

Update Cardinal Commit
Signed-off-by: sre-ci-robot [email protected]

Copy link

mergify bot commented Jul 11, 2024

@sre-ci-robot 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link
Collaborator

@chasingegg chasingegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to align interface change between cardinal and knowhere

/lgtm

@sre-ci-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, sre-ci-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chasingegg
Copy link
Collaborator

/kind improvement

@sre-ci-robot sre-ci-robot merged commit 6131f94 into main Jul 11, 2024
5 of 8 checks passed
@chasingegg chasingegg deleted the update_cardinal_commit_1ad7db441ce3dbdb187facfdc7d66087631ebc5e branch July 11, 2024 10:12
xxxlzhxxx pushed a commit to xxxlzhxxx/knowhere that referenced this pull request Jul 23, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants