Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick]Replace gettid() with syscall(SYS_gettid) #697

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

xige-16
Copy link

@xige-16 xige-16 commented Jul 10, 2024

pr: #396
/kind bug
issue: #696

@sre-ci-robot
Copy link
Collaborator

Welcome @xige-16! It looks like this is your first PR to zilliztech/knowhere 🎉

Copy link

mergify bot commented Jul 10, 2024

@xige-16 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

mergify bot commented Jul 10, 2024

@xige-16 e2e jenkins job failed, comment /run-e2e can trigger the job again.

@alexanderguzhva
Copy link
Collaborator

/lgtm

@alexanderguzhva
Copy link
Collaborator

/run-e2e

@liliu-z
Copy link
Collaborator

liliu-z commented Jul 11, 2024

/kind improvement

@xige-16
Copy link
Author

xige-16 commented Jul 12, 2024

/run-e2e

@xige-16
Copy link
Author

xige-16 commented Jul 12, 2024

e2e is as unstable as milvus. haha.

@xige-16
Copy link
Author

xige-16 commented Jul 15, 2024

/run-e2e

@liliu-z
Copy link
Collaborator

liliu-z commented Jul 16, 2024

e2e is as unstable as milvus. haha.

Looks like it is not about stability but some E2E issue. Plz take a check today. @cydrain

Copy link

mergify bot commented Jul 16, 2024

@xige-16 e2e jenkins job failed, comment /run-e2e can trigger the job again.

@cydrain
Copy link
Collaborator

cydrain commented Jul 16, 2024

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Jul 16, 2024
@cydrain cydrain merged commit 9296231 into zilliztech:2.2 Jul 16, 2024
7 of 9 checks passed
@mergify mergify bot removed the ci-passed label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants