Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data type conversion test #653

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Jun 17, 2024

No description provided.

@sre-ci-robot sre-ci-robot requested review from hhy3 and zhengbuqian June 17, 2024 10:54
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cydrain
Copy link
Collaborator Author

cydrain commented Jun 17, 2024

/kind improvement

Copy link

mergify bot commented Jun 17, 2024

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.27%. Comparing base (3c46f4c) to head (cb9d16d).
Report is 92 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #653       +/-   ##
=========================================
+ Coverage      0   71.27%   +71.27%     
=========================================
  Files         0       69       +69     
  Lines         0     4728     +4728     
=========================================
+ Hits          0     3370     +3370     
- Misses        0     1358     +1358     

see 69 files with indirect coverage changes

@cydrain cydrain force-pushed the caiyd_add_multi_data_type_ut branch from 259b3a9 to cb9d16d Compare June 18, 2024 09:52
@zhengbuqian
Copy link
Collaborator

/lgtm

@mergify mergify bot added the ci-passed label Jun 18, 2024
@sre-ci-robot sre-ci-robot merged commit 44b7cbb into zilliztech:main Jun 18, 2024
13 checks passed
@cydrain cydrain deleted the caiyd_add_multi_data_type_ut branch June 19, 2024 02:56
xxxlzhxxx pushed a commit to xxxlzhxxx/knowhere that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants