Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index and data type check function #649

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

cqy123456
Copy link
Collaborator

@cqy123456 cqy123456 commented Jun 14, 2024

issue: #650

Copy link

mergify bot commented Jun 14, 2024

@cqy123456 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines 53 to 56
{IndexEnum::INDEX_FAISS_GPU_IDMAP, VecType::VECTOR_FLOAT},
{IndexEnum::INDEX_FAISS_GPU_IVFFLAT, VecType::VECTOR_FLOAT},
{IndexEnum::INDEX_FAISS_GPU_IVFPQ, VecType::VECTOR_FLOAT},
{IndexEnum::INDEX_FAISS_GPU_IVFSQ8, VecType::VECTOR_FLOAT},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's block this

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.34%. Comparing base (3c46f4c) to head (7e6c6b6).
Report is 91 commits behind head on main.

Current head 7e6c6b6 differs from pull request most recent head 646d314

Please upload reports for the commit 646d314 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #649       +/-   ##
=========================================
+ Coverage      0   70.34%   +70.34%     
=========================================
  Files         0       69       +69     
  Lines         0     4728     +4728     
=========================================
+ Hits          0     3326     +3326     
- Misses        0     1402     +1402     

see 69 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 14, 2024
@sre-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Jun 14, 2024
@mergify mergify bot removed the ci-passed label Jun 14, 2024
@liliu-z liliu-z merged commit 5654078 into zilliztech:main Jun 14, 2024
7 of 10 checks passed
@liliu-z
Copy link
Collaborator

liliu-z commented Jun 14, 2024

/kind improvement

@liliu-z
Copy link
Collaborator

liliu-z commented Jun 14, 2024

/lgtm

xxxlzhxxx pushed a commit to xxxlzhxxx/knowhere that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants