Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make GetIsSparse const #627

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

zhengbuqian
Copy link
Collaborator

minor fix
/kind improvement

Signed-off-by: Buqian Zheng <[email protected]>
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.29%. Comparing base (3c46f4c) to head (f321236).
Report is 80 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #627       +/-   ##
=========================================
+ Coverage      0   70.29%   +70.29%     
=========================================
  Files         0       67       +67     
  Lines         0     4719     +4719     
=========================================
+ Hits          0     3317     +3317     
- Misses        0     1402     +1402     

see 67 files with indirect coverage changes

@cydrain
Copy link
Collaborator

cydrain commented Jun 4, 2024

/lgtm

Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [liliu-z,zhengbuqian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liliu-z liliu-z merged commit c7fb550 into zilliztech:main Jun 4, 2024
11 of 12 checks passed
@zhengbuqian zhengbuqian deleted the get-is-sparse branch June 4, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants