Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iterator based range search #601

Merged

Conversation

zhengbuqian
Copy link
Collaborator

kind/bug
issue: #600

/hold

hold for #599 to merge first

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented May 24, 2024

@zhengbuqian 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.29%. Comparing base (3c46f4c) to head (b37e4e7).
Report is 72 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #601       +/-   ##
=========================================
+ Coverage      0   70.29%   +70.29%     
=========================================
  Files         0       67       +67     
  Lines         0     4719     +4719     
=========================================
+ Hits          0     3317     +3317     
- Misses        0     1402     +1402     

see 67 files with indirect coverage changes

@buqian-zilliz buqian-zilliz force-pushed the fix-iterator-based-range-search branch from e1255db to 51a8534 Compare May 27, 2024 02:51
@zhengbuqian
Copy link
Collaborator Author

/unhold

/kind bug

@zhengbuqian
Copy link
Collaborator Author

issue: #600

@zhengbuqian
Copy link
Collaborator Author

/run-e2e

@buqian-zilliz buqian-zilliz force-pushed the fix-iterator-based-range-search branch from 51a8534 to b37e4e7 Compare May 27, 2024 03:38
@mergify mergify bot added the ci-passed label May 27, 2024
@cydrain
Copy link
Collaborator

cydrain commented May 27, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 4c86850 into zilliztech:main May 27, 2024
11 of 12 checks passed
@zhengbuqian zhengbuqian deleted the fix-iterator-based-range-search branch May 27, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants