Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip e2e] Update cardinal commit #584

Merged
merged 1 commit into from
May 23, 2024

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented May 23, 2024

/kind improvement
issue: #456

Signed-off-by: xianliang.li <[email protected]>
Copy link

mergify bot commented May 23, 2024

@foxspy 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@mergify mergify bot added the ci-passed label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.26%. Comparing base (3c46f4c) to head (2f4862a).
Report is 51 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #584       +/-   ##
=========================================
+ Coverage      0   70.26%   +70.26%     
=========================================
  Files         0       67       +67     
  Lines         0     4715     +4715     
=========================================
+ Hits          0     3313     +3313     
- Misses        0     1402     +1402     

see 67 files with indirect coverage changes

Copy link
Collaborator

@chasingegg chasingegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@foxspy
Copy link
Collaborator Author

foxspy commented May 23, 2024

issue: #456

Copy link

mergify bot commented May 23, 2024

@foxspy Please remove redundant kind/xxx labels and make sure that there is only one kind/xxx label of your Pull Request. (eg. “/remove-kind improvement”)

@sre-ci-robot sre-ci-robot merged commit 22186b6 into zilliztech:main May 23, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants