Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kmeans init dead loop when dist is inf #574

Merged
merged 1 commit into from
May 21, 2024

Conversation

chasingegg
Copy link
Collaborator

@chasingegg chasingegg commented May 21, 2024

/kind bug

Close #575

@sre-ci-robot sre-ci-robot added the kind/bug This PR is a bug fix label May 21, 2024
@sre-ci-robot sre-ci-robot requested review from cqy123456 and liliu-z May 21, 2024 04:13
@mergify mergify bot added the dco-passed label May 21, 2024
Copy link

mergify bot commented May 21, 2024

@chasingegg 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@chasingegg chasingegg changed the title Fix kmeans init dead loop when ist is inf Fix kmeans init dead loop when dist is inf May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (3c46f4c) to head (8b28f64).
Report is 44 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #574       +/-   ##
=========================================
+ Coverage      0   70.04%   +70.04%     
=========================================
  Files         0       67       +67     
  Lines         0     4597     +4597     
=========================================
+ Hits          0     3220     +3220     
- Misses        0     1377     +1377     

see 67 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 21, 2024
Copy link
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 39c0a73 into zilliztech:main May 21, 2024
11 checks passed
@chasingegg chasingegg deleted the fix-kmeans-pp branch May 21, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: kmeans init dead loop when distance is inf
3 participants