Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate #3166 from Faiss baseline #563

Merged
merged 1 commit into from
May 15, 2024

Conversation

alexanderguzhva
Copy link
Collaborator

@alexanderguzhva alexanderguzhva commented May 13, 2024

issue #462

Faiss baseline PRs:

Basically, this PR implements ARM NEON code for ScalarQuantizer.

All knowhere tests pass on my ARM machine.

Copy link

mergify bot commented May 13, 2024

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (3c46f4c) to head (d09effb).
Report is 41 commits behind head on main.

❗ Current head d09effb differs from pull request most recent head 4e07caf. Consider uploading reports for the commit 4e07caf to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #563       +/-   ##
=========================================
+ Coverage      0   70.04%   +70.04%     
=========================================
  Files         0       67       +67     
  Lines         0     4597     +4597     
=========================================
+ Hits          0     3220     +3220     
- Misses        0     1377     +1377     

see 67 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 13, 2024
@alexanderguzhva
Copy link
Collaborator Author

/hold

@alexanderguzhva
Copy link
Collaborator Author

added even more removed instructions
/unhold

@PwzXxm
Copy link
Collaborator

PwzXxm commented May 15, 2024

/lgtm

@PwzXxm
Copy link
Collaborator

PwzXxm commented May 15, 2024

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, PwzXxm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PwzXxm
Copy link
Collaborator

PwzXxm commented May 15, 2024

/kind enhancement

@sre-ci-robot sre-ci-robot merged commit e0c9c41 into zilliztech:main May 15, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants