Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unused range util for faiss #517

Merged
merged 1 commit into from
Apr 23, 2024
Merged

removed unused range util for faiss #517

merged 1 commit into from
Apr 23, 2024

Conversation

zhengbuqian
Copy link
Collaborator

/kind improvement

@sre-ci-robot sre-ci-robot requested review from hhy3 and PwzXxm April 23, 2024 02:02
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed label Apr 23, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.14%. Comparing base (3c46f4c) to head (df888d8).
Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #517       +/-   ##
=========================================
+ Coverage      0   71.14%   +71.14%     
=========================================
  Files         0       67       +67     
  Lines         0     4401     +4401     
=========================================
+ Hits          0     3131     +3131     
- Misses        0     1270     +1270

see 67 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 23, 2024
cydrain
cydrain reviewed Apr 23, 2024
View reviewed changes
src/common/range_util.cc
}

void
GetRangeSearchResult(const faiss::RangeSearchResult& res, const bool is_ip, const int64_t nq, const float radius,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this API is used in flat.cc and ivf.cc, please double check

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the GetRangeSearchResult(const std::vector<std::vector<float>>& result_distances, const std::vector<std::vector<int64_t>>& result_labels variant is used there

@cydrain
Copy link
Collaborator

cydrain commented Apr 23, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 7f18b02 into zilliztech:main Apr 23, 2024
11 checks passed
@zhengbuqian zhengbuqian deleted the remove-unused-range-util-faiss branch April 23, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain cydrain left review comments

@hhy3 hhy3 Awaiting requested review from hhy3

@PwzXxm PwzXxm Awaiting requested review from PwzXxm

Assignees

@cydrain cydrain

Labels
approved ci-passed dco-passed kind/improvement lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhengbuqian @sre-ci-robot @cydrain