-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sparse: accelerate the writing of index files #1017
Conversation
@sparknack 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
=========================================
+ Coverage 0 73.91% +73.91%
=========================================
Files 0 82 +82
Lines 0 6981 +6981
=========================================
+ Hits 0 5160 +5160
- Misses 0 1821 +1821 |
It is too slow to construct the index file using the DAAT cursor method. Switch to the TAAT traversal method instead. Signed-off-by: Shawn Wang <[email protected]>
37b8c47
to
52ee7e2
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sparknack, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #967 |
/kind improvement |
Since we remove forward index in #1011 , sparse row data for index file should reconstructed from inverted index. But it is too slow to construct the index file using the DAAT cursor method. Switch to the TAAT traversal method instead.