Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make FileReader to close fd using RAII #1005

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

zhengbuqian
Copy link
Collaborator

@zhengbuqian zhengbuqian commented Dec 24, 2024

/kind bug

issue: #1004
#1004

@sre-ci-robot
Copy link
Collaborator

@zhengbuqian: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

In response to this:

/kind fix
issue: #1004

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Dec 24, 2024

@zhengbuqian 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@foxspy
Copy link
Collaborator

foxspy commented Dec 24, 2024

/lgtm

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.03%. Comparing base (3c46f4c) to head (d72e7e0).
Report is 279 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1005       +/-   ##
=========================================
+ Coverage      0   74.03%   +74.03%     
=========================================
  Files         0       82       +82     
  Lines         0     6960     +6960     
=========================================
+ Hits          0     5153     +5153     
- Misses        0     1807     +1807     

see 82 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 24, 2024
@alexanderguzhva
Copy link
Collaborator

/lgtm

@alexanderguzhva
Copy link
Collaborator

issue: #1004

@foxspy
Copy link
Collaborator

foxspy commented Dec 25, 2024

/kind improvement

@sre-ci-robot sre-ci-robot merged commit 6a691f6 into zilliztech:main Dec 25, 2024
14 checks passed
@zhengbuqian zhengbuqian deleted the raii-file-reader branch December 25, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants