Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom case cli bug, refactoring and README updates. #384

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

Sheharyar570
Copy link
Contributor

This PR includes the following changes.

  1. Fixed custom_case key error in parameters dict in CLI command.
  2. Refactored command options, replaced no-custom-dataset-use-shuffled and no-custom-dataset-with-gt with skip-custom-dataset-use-shuffled and skip-custom-dataset-with-gt for consistency.
  3. Added custom case related command options information.
  4. Added instruction to include custom_case while adding the CLI support for the client.

@Sheharyar570
Copy link
Contributor Author

/assign @XuanYang-cn

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013, Sheharyar570
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alwayslove2013 alwayslove2013 merged commit 51390b7 into zilliztech:main Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants