Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to new pgvecto_rs sdk #353

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

cutecutecat
Copy link
Contributor

@cutecutecat cutecutecat commented Jul 30, 2024

Close #327

This PR migrated to our new SDK of pgvecto.rs after v0.3:

  • psycopg2 -> pgvecto_rs[psycopg3]>=0.2.1

And we add client support for pgvecto.rs.

Apart from that, we fix a commit wrong use, thanks to @frg01.

How to test it

Please use one of these images to test:

  • tensorchord/pgvecto-rs:pg16-v0.3.0

How to run image

docker run  --name pgvecto-rs-demo  \
-e POSTGRES_PASSWORD=mysecretpassword -p 5432:5432   \
-d tensorchord/pgvecto-rs:pg16-v0.3.0

Field at Benchmark Webpage

password=mysecretpassword
db_name=postgres

Supported Index types

  • HNSW
  • IVF_FLAT
  • FLAT

Warning

We have noticed optimize timeout due to #340 (comment)

WARNING: VectorDB optimize timeout in 1800 (task_runner.py:249) (899895)
WARNING: Failed to run performance case, reason = Performance case optimize timeout

Index build time estimate at AWS:

  • 3500s at 2c when max_parallel_workers=2
  • 1700s at 4c when max_parallel_workers=4

@alwayslove2013 alwayslove2013 self-requested a review July 30, 2024 07:09
@alwayslove2013 alwayslove2013 merged commit f248805 into zilliztech:main Aug 1, 2024
4 checks passed
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013, cutecutecat
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alwayslove2013 pushed a commit to alwayslove2013/VectorDBBench that referenced this pull request Aug 7, 2024
@wahajali
Copy link
Contributor

wahajali commented Aug 9, 2024

@cutecutecat I have one question regarding pgvecto_rs and pgvector clients -- would it improve the QPS performance if the clients started using SQL functions. If we use those that should increase the QPS, as lesser network bandwidth.

@cutecutecat cutecutecat deleted the pgvectors-refactor branch September 24, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【PgVectoRS】wrong use of commit
4 participants