-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Espressif System Zigbee radio library support #45
base: dev
Are you sure you want to change the base?
Conversation
@puddly #42 have been closed and PTAL this PR for the new name. the zigpy-espzb project on my personal account https://github.com/lhespress/zigpy-espzb. Thanks. |
Thank you! I've made a pull request that fixes CI in your repository. Once that is tested and merged, I can write some instructions for how to create a package release and publish it to PyPI. You can currently see that CI is failing for this pull request because the |
3074b27
to
39f6642
Compare
@lhespress nitpicking and maybe trivial, however as suggested by puddly in #42 perhaps would it not be a a good idea before this is established if also the new radio type was renamed from Perhaps just my dyslexia but when I am reading 39f6642#diff-bb72967ef9d1e64ff68ad3f1a4e13e19b4cc7f05359c100016f76560fbaea52c Line 17 in 39f6642
Line 62 in 39f6642
|
Hi @lhespress , I’ve noticed that the PR has been sitting idle for a bit. I am currently trying to use the ZHA integration on an ESP32C6 with the ESP NCP firmware, the work you’ve done is amazing and helpful, so I think we need to complete this PR. If you don’t have the time, I’d be happy to step in and take care of the remaining tasks. |
@Maxwelltoo It's great if you can help. |
@lhespress Do you also plan on prioritizing writing/adding additonal unit tests in this radio library for zigpy? For reference please see the https://github.com/zigpy/bellows/tree/dev/tests |
@Hedda You already posted this as an issue, there's no need to duplicate it here. Furthermore, the library is not even functional yet so it is way too early to require unit tests. Please reduce the chatter. You've opened nearly two thirds of the 30 issues in the zigpy-zboss repository. For the zigpy-espzb repo, 9/10 are yours. This is too much. |
39f6642
to
3b91e1a
Compare
No description provided.