Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bellows CLI #637

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Fix bellows CLI #637

merged 4 commits into from
Jul 23, 2024

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Jul 23, 2024

I've removed network backup and restore from the bellows CLI. It is too complex to maintain and should be kept in zigpy-cli.

The rest of the tools were spot checked and run.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (93c671b) to head (a8566fb).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #637   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          50       50           
  Lines        3459     3459           
=======================================
  Hits         3430     3430           
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly
Copy link
Contributor Author

puddly commented Jul 23, 2024

In the future, we need to remove the bellows CLI entirely. This has a few blockers:

  • Add the --i-understand-... flag to zigpy-cli, maybe call it --burn?
  • Implement radio-agnostic sniffing.
  • Add more options for network formation (forcing a PAN ID, EPID, channel, key, IEEE address, and so on).
  • Maybe add a way to send ZCL commands to devices?

@puddly puddly merged commit c4578a0 into zigpy:dev Jul 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant