Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental: remove legacy cases, add some new ones #21961

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

mlugg
Copy link
Member

@mlugg mlugg commented Nov 11, 2024

See commit messages. I originally planned to port all of the old cases, but I determined that essentially none of them were testing anything interesting.

…ases

These cases have been disabled for a while, and we have transitioned to
using a compact file format for incremental test cases.

I was originally planning to port all of these cases, but the vast
majority aren't testing anything interesting, so it wasn't worth the
effort. I did look through each one; anything interesting being tested
has been extracted into a new case in `test/incremental/`.

Two of the new tests are currently failing with the self-hosted ELF
linker, and thus are currently only enabled with the C backend.

Resolves: ziglang#12844
This is similar to the old `llvm/shift_right_plus_left` case, which was
disabled by 1b1c78c. The case is not enabled on the LLVM backend, since
incremental compilation support for this backend is a work in progress
and is tracked by ziglang#21165. It passes on the x86_64-linux target with the
self-hosted backend.

Resolves: ziglang#12288
@mlugg mlugg merged commit 28bdab3 into ziglang:master Nov 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant