Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64_be-linux-* to module tests #21910

Closed
wants to merge 6 commits into from

Conversation

alexrp
Copy link
Member

@alexrp alexrp commented Nov 4, 2024

Experimenting to try to resolve the issue in #21911 and get 4049be9 re-landed...

@alexrp alexrp force-pushed the clone-unwind-protection branch 2 times, most recently from ccaa7b7 to e852112 Compare November 4, 2024 20:20
@alexrp alexrp marked this pull request as draft November 5, 2024 08:33
@alexrp alexrp changed the title std.os.linux: Add unwinding protection in clone() implementations Add aarch64_be-linux-* to module tests Nov 5, 2024
The unwind info in the child process will be wrong, so explicitly zero out the
frame pointer (for FP-based unwinders) and mark the link register as undefined
(for DWARF-based unwinders).

I only zeroed the frame pointer(s) on Arm/Thumb because LLVM's assembler really
doesn't like .cantunwind directives in inline assembly.
@alexrp
Copy link
Member Author

alexrp commented Nov 12, 2024

I'm now fairly confident that 565be08 resolves the unwind failure seen in #21911. Will open a new PR with that commit extended to all architectures in musl.

@alexrp alexrp closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant