feat/blocktxn #154
Closed
feat/blocktxn #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelabro
requested changes
Oct 3, 2024
|
this code is for |
|
|
|
@guha-rahul, @bloomingpeach is right, you confused both payload |
tdelabro
requested changes
Oct 4, 2024
ybensacq
reviewed
Oct 4, 2024
ybensacq
reviewed
Oct 4, 2024
ybensacq
reviewed
Oct 7, 2024
| @@ -98,8 +101,11 @@ pub const Message = union(MessageTypes) { | |||
| .filteradd => |*m| m.deinit(allocator), | |||
| .getdata => |*m| m.deinit(allocator), | |||
| .cmpctblock => |*m| m.deinit(allocator), | |||
| .sendheaders => {}, | |||
| .filterload => {}, | |||
There was a problem hiding this comment.
it can be removed, because managed in the else.
ybensacq
reviewed
Oct 7, 2024
| const serialized = try msg.genericSerialize(test_allocator); | ||
| defer test_allocator.free(serialized); | ||
|
|
||
| const deserialized = try BlockTxnMessage.genericDeserializeSlice(test_allocator, serialized); |
There was a problem hiding this comment.
you have to use deserialize from BlockTxnMessage not the generic one
|
@guha-rahul I'm closing this PR as the project is put in hold. I will still pay you for the work done on OD tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #102