Bug fix for https://github.com/zhouhan0126/WIFIMANAGER-ESP32/issues/1… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2018 14:26
|
I've added some commits that add some possibilities : add labels to the form when adding parameters, get parameters from the WiFiManager object and most importantly fix a tiny bug, especially annoying for parameters of length 1 since the store operation did not take into account the extra-byte necessary for the null character at the end of the string. |
added 2 commits
February 6, 2018 13:56
…the store operation did not take into account the extra-byte for the end of string character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… : disconnect the AP before trying to connect in STA mode.
Well that's pretty much self-explanatory : I investigated a bit and found quite strange that before trying to connect to an AP we don't turn off the AP created by WiFiManager. @zhouhan0126 I also created a fork of arduino-esp32 that fixes a problem with DNS Server (which is now integrated in the repository) and with both forks, I have a working WiFiManager (self portal works great and it connects to the AP when saving the credentials).