Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add text style editing support to bottom navigation bar theme editor #549

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

zeshuaro
Copy link
Owner

Relate to #528

image

@zeshuaro zeshuaro added the enhancement New feature or request label Dec 18, 2022
@zeshuaro zeshuaro force-pushed the feat/bottom-navigation-bar-font-family branch from b772ee7 to 6474ea3 Compare December 18, 2022 02:33
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 96.97% // Head: 96.99% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (6474ea3) compared to base (bb59dad).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   96.97%   96.99%   +0.02%     
==========================================
  Files         111      111              
  Lines        4160     4193      +33     
==========================================
+ Hits         4034     4067      +33     
  Misses        126      126              
Flag Coverage Δ
appainter 97.32% <100.00%> (+0.02%) ⬆️
appainter_builder 78.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/tab_bar_theme/view/tab_bar_theme_editor.dart 100.00% <ø> (ø)
...theme/cubit/bottom_navigation_bar_theme_cubit.dart 100.00% <100.00%> (ø)
...theme/view/bottom_navigation_bar_theme_editor.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zeshuaro zeshuaro merged commit 6d96463 into main Dec 18, 2022
@zeshuaro zeshuaro deleted the feat/bottom-navigation-bar-font-family branch December 18, 2022 05:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant