Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : 有时存在nacos假注册的问题,服务无法发现,导致请求异常. 现在修改为注册实例后校验实例信息, 注册失败则返回 #302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FIX : 有时存在nacos假注册的问题,服务无法发现,导致请求异常. 现在修改为注册实例后校验实例信息, 注册失败则返回 #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion zrpc/registry/nacos/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func RegisterService(opts *Options) error {
}

// service register
_, err = client.RegisterInstance(vo.RegisterInstanceParam{
registerStatus, err := client.RegisterInstance(vo.RegisterInstanceParam{
ServiceName: opts.ServiceName,
Ip: host,
Port: port,
Expand All @@ -54,6 +54,20 @@ func RegisterService(opts *Options) error {
return err
}

// check register instance status
if registerStatus == false {
return fmt.Errorf("failed to register instance, status is %v", registerStatus)
}

// get register info
_, err = client.GetService(vo.GetServiceParam{
ServiceName: opts.ServiceName,
GroupName: opts.Group,
})
if err != nil {
return err
}

// service deregister
proc.AddShutdownListener(func() {
_, err := client.DeregisterInstance(vo.DeregisterInstanceParam{
Expand Down