Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metrics #3624

Merged
merged 5 commits into from
Oct 26, 2023
Merged

feat: add metrics #3624

merged 5 commits into from
Oct 26, 2023

Conversation

MarkJoyMa
Copy link
Collaborator

No description provided.

@MarkJoyMa MarkJoyMa added the do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion. label Oct 14, 2023
@MarkJoyMa MarkJoyMa requested a review from re-dylan October 14, 2023 05:18
@codecov
Copy link

codecov bot commented Oct 14, 2023 •
edited
Loading

Codecov Report

Merging #3624 (18bebec) into master (199e860) will increase coverage by 0.02%.
The diff coverage is 95.25%.

Files Coverage Δ
core/metric/histogram.go 100.00% <100.00%> (ø)
core/stores/redis/hook.go 96.49% <100.00%> (+0.03%) ⬆️
core/stores/redis/metrics.go 100.00% <100.00%> (ø)
core/stores/sqlx/metrics.go 100.00% <100.00%> (ø)
core/stores/sqlx/stmt.go 100.00% <100.00%> (ø)
...ternal/clientinterceptors/prometheusinterceptor.go 100.00% <ø> (ø)
...ternal/serverinterceptors/prometheusinterceptor.go 100.00% <ø> (ø)
core/stores/redis/redisclientmanager.go 81.25% <57.14%> (-6.75%) ⬇️
core/stores/redis/redisclustermanager.go 85.71% <57.14%> (-5.72%) ⬇️
rest/httpc/internal/metricsinterceptor.go 78.57% <78.57%> (ø)

... and 1 file with indirect coverage changes

kevwan
kevwan reviewed Oct 14, 2023
View reviewed changes
core/metric/histogram.go Outdated Show resolved Hide resolved
core/stores/sqlx/metrics.go Outdated Show resolved Hide resolved
@MarkJoyMa MarkJoyMa removed the do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion. label Oct 26, 2023
@kevwan kevwan added this pull request to the merge queue Oct 26, 2023
Merged via the queue into zeromicro:master with commit c05e03b Oct 26, 2023
6 checks passed
@sunshujie1990 sunshujie1990 mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan left review comments

@re-dylan re-dylan re-dylan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkJoyMa @kevwan @re-dylan