Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the SIGINT signal in signals.go to subscribe the user input ctrl+c to exit the application operation #3611

Merged
merged 1 commit into from
Oct 15, 2023
Merged

feat: add the SIGINT signal in signals.go to subscribe the user input ctrl+c to exit the application operation #3611

merged 1 commit into from
Oct 15, 2023

Conversation

Suyghur
Copy link
Contributor

@Suyghur Suyghur commented Oct 9, 2023

I think it's useful in coding

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #3611 (56d2093) into master (d71c0da) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Files Coverage Δ
core/proc/signals.go 43.33% <50.00%> (ø)

... and 1 file with indirect coverage changes

@Suyghur
Copy link
Contributor Author

Suyghur commented Oct 9, 2023

help to code review, plz~ @kevwan

@Suyghur Suyghur changed the title feat: add the SIGINT signal in signals.go to listen for the user enter ctrl+c to exit the application operation feat: add the SIGINT signal in signals.go to subscribe the user input ctrl+c to exit the application operation Oct 9, 2023
@zeromicro zeromicro deleted a comment from Issues-translate-bot Oct 9, 2023
@kevwan
Copy link
Contributor

kevwan commented Oct 9, 2023

I don't think it's necessary in coding stage. Because if so, interrupting takes couple seconds.

@Suyghur
Copy link
Contributor Author

Suyghur commented Oct 9, 2023

I don't think it's necessary in coding stage. Because if so, interrupting takes couple seconds.

it brings the coding stage as close as possible to the pro env

@kevwan
Copy link
Contributor

kevwan commented Oct 9, 2023 •
edited
Loading

I don't think it's necessary in coding stage. Because if so, interrupting takes couple seconds.

it brings the coding stage as close as possible to the pro env

We might need some discussion. Reply later. Thanks!

@kevwan kevwan merged commit 95b7a3d into zeromicro:master Oct 15, 2023
@Suyghur Suyghur deleted the feat/signals branch October 17, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Suyghur @kevwan