use strings.Contains instead of strings.Index

zeromicro · Aug 11, 2020 · c57051c · c57051c
1 parent 08fa64d
commit c57051c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/core/logx/logs_test.go b/core/logx/logs_test.go
@@ -37,7 +37,7 @@ func (mw *mockWriter) Reset() {
 }
 
 func (mw *mockWriter) Contains(text string) bool {
-	return strings.Index(mw.builder.String(), text) > -1
+	return strings.Contains(mw.builder.String(), text)
 }
 
 func TestFileLineFileMode(t *testing.T) {

diff --git a/rest/httpx/requests.go b/rest/httpx/requests.go
@@ -39,7 +39,7 @@ func Parse(r *http.Request, v interface{}) error {
 
 // Parses the form request.
 func ParseForm(r *http.Request, v interface{}) error {
-	if strings.Index(r.Header.Get(ContentType), multipartFormData) != -1 {
+	if strings.Contains(r.Header.Get(ContentType), multipartFormData) {
 		if err := r.ParseMultipartForm(maxMemory); err != nil {
 			return err
 		}
@@ -107,5 +107,5 @@ func ParsePath(r *http.Request, v interface{}) error {
 }
 
 func withJsonBody(r *http.Request) bool {
-	return r.ContentLength > 0 && strings.Index(r.Header.Get(ContentType), ApplicationJson) != -1
+	return r.ContentLength > 0 && strings.Contains(r.Header.Get(ContentType), ApplicationJson)
 }